Commit d46e1921 by Bernardo Rittmeyer

get_dirty() comparison is not type safe

get_dirty() must compare using Not Identical (!==) on place of Not Equal (!=).
For example, changing null to false don't make the model dirty.
parent 5dd3ec6f
...@@ -517,7 +517,7 @@ abstract class Model { ...@@ -517,7 +517,7 @@ abstract class Model {
foreach ($this->attributes as $key => $value) foreach ($this->attributes as $key => $value)
{ {
if ( ! array_key_exists($key, $this->original) or $value != $this->original[$key]) if ( ! array_key_exists($key, $this->original) or $value !== $this->original[$key])
{ {
$dirty[$key] = $value; $dirty[$key] = $value;
} }
...@@ -795,4 +795,4 @@ abstract class Model { ...@@ -795,4 +795,4 @@ abstract class Model {
return call_user_func_array(array(new $model, $method), $parameters); return call_user_func_array(array(new $model, $method), $parameters);
} }
} }
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment