Commit 895d8764 by Taylor Otwell

fixed bugs found when unit testing.

parent 9caf239f
...@@ -14,14 +14,14 @@ class Response { ...@@ -14,14 +14,14 @@ class Response {
* *
* @var int * @var int
*/ */
protected $status; public $status;
/** /**
* The response headers. * The response headers.
* *
* @var array * @var array
*/ */
protected $headers = array(); public $headers = array();
/** /**
* HTTP status codes. * HTTP status codes.
......
...@@ -28,9 +28,9 @@ abstract class Controller { ...@@ -28,9 +28,9 @@ abstract class Controller {
* For example, a destination of "user.profile@show" would call the User_Profile * For example, a destination of "user.profile@show" would call the User_Profile
* controller's show method with the given parameters. * controller's show method with the given parameters.
* *
* @param string $destination * @param string $destination
* @param array $parameters * @param array $parameters
* @return mixed * @return Response
*/ */
public static function call($destination, $parameters = array()) public static function call($destination, $parameters = array())
{ {
...@@ -43,30 +43,12 @@ abstract class Controller { ...@@ -43,30 +43,12 @@ abstract class Controller {
$controller = static::resolve($controller); $controller = static::resolve($controller);
if (is_null($controller) or static::hidden($method)) if (is_null($controller))
{ {
return Response::error('404'); return Response::error('404');
} }
// Again, as was the case with route closures, if the controller return $controller->execute($method, $parameters);
// "before" filters return a response, it will be considered the
// response to the request and the controller method will not be
// used to handle the request to the application.
$response = Filter::run($controller->filters('before'), array(), true);
if (is_null($response))
{
$response = call_user_func_array(array($controller, $method), $parameters);
}
// The after filter and the framework expects all responses to
// be instances of the Response class. If the method did not
// return an instsance of Response, we will make on now.
if ( ! $response instanceof Response) $response = new Response($response);
Filter::run($controller->filters('after'), array($response));
return $response;
} }
/** /**
...@@ -106,7 +88,7 @@ abstract class Controller { ...@@ -106,7 +88,7 @@ abstract class Controller {
if (file_exists($path = CONTROLLER_PATH.$controller.EXT)) if (file_exists($path = CONTROLLER_PATH.$controller.EXT))
{ {
require $path; require_once $path;
return true; return true;
} }
...@@ -115,6 +97,41 @@ abstract class Controller { ...@@ -115,6 +97,41 @@ abstract class Controller {
} }
/** /**
* Execute a controller method with the given parameters.
*
* @param string $method
* @param array $parameters
* @return Response
*/
public function execute($method, $parameters = array())
{
if (static::hidden($method))
{
return Response::error('404');
}
// Again, as was the case with route closures, if the controller
// "before" filters return a response, it will be considered the
// response to the request and the controller method will not be
// used to handle the request to the application.
$response = Filter::run($this->filters('before'), array(), true);
if (is_null($response))
{
$response = call_user_func_array(array($this, $method), $parameters);
}
// The after filter and the framework expects all responses to
// be instances of the Response class. If the method did not
// return an instsance of Response, we will make on now.
if ( ! $response instanceof Response) $response = new Response($response);
Filter::run($this->filters('after'), array($response));
return $response;
}
/**
* Determine if a given controller method is callable. * Determine if a given controller method is callable.
* *
* @param string $method * @param string $method
......
...@@ -186,7 +186,9 @@ class Route { ...@@ -186,7 +186,9 @@ class Route {
{ {
if (is_array($this->callback) and isset($this->callback[$name])) if (is_array($this->callback) and isset($this->callback[$name]))
{ {
return (array) $this->callback[$name]; $filters = $this->callback[$name];
return (is_string($filters)) ? explode('|', $filters) : (array) $filters;
} }
return array(); return array();
......
...@@ -272,7 +272,7 @@ class Router { ...@@ -272,7 +272,7 @@ class Router {
for ($i = 0; $i < $count; $i++) for ($i = 0; $i < $count; $i++)
{ {
if (preg_match('/\(.+\)/', $route[$i])) if (preg_match('/\(.+\)/', $route[$i]) and isset($uri[$i]))
{ {
$parameters[] = $uri[$i]; $parameters[] = $uri[$i];
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment